Merged
Conversation
The deploy-docs job sets RUSTDOCFLAGS='--cfg docsrs' which activates `#![cfg_attr(docsrs, feature(doc_cfg))]` in lib.rs. Since feature(doc_cfg) is a nightly-only feature, the build fails with stable Rust 1.90: error[E0554]: `#![feature]` may not be used on the stable release channel Switch the deploy-docs job to use nightly Rust, which is the standard practice for documentation builds (docs.rs also uses nightly). The separate 'docs' CI check job remains on stable since it doesn't set the docsrs cfg. Co-authored-by: Greg Nazario <greg@gnazar.io>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix documentation CI failure by using nightly Rust for the
deploy-docsjob, as thedoc_cfgfeature requires it.